-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of make_bcs tools that generate raster and tile files #763
Conversation
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/mkEASETilesParam.F90
Outdated
Show resolved
Hide resolved
- rewrote some code blocks for clarity and efficiency - removed obsolete variable declarations - removed obsolete use statements - added "only:" qualifier to some use statement - commented out obsolete code blocks - renamed some variables for clarity - removed repetition of identical operations - added comments - white-space changes for improved readability
…on of data in GEOS5_10arcsec_mask.nc (mkEASETilesParam.F90)
…rint statements (mkEASETilesParam.F90)
…r of tiles (mkEASETilesParam.F90)
- cleaned-up 1-dim indexing for EASE and raster grid cells - renamed loop counter variables for clarity - cleaned up hardwired target for global mean elevation - edited comments for clarity - removed obsolete code
@weiyuan-jiang, @biljanaorescanin: I ended up in the rabbit hole of cleaning up mkEASETilesParam.F90. Here's a summary of where things stand right now:
cc: @rdkoster |
I've moved one set of EASEv2_M36 to the area. I've run test with both make_bcs and make_bcs.py and result is the same between the two and is zero diff to what we have on develop.
|
Update on earlier comments:
The latter was confirmed by analyzing existing catchment.def and *.rst files. Going forward, a fix and new EASE bcs version will be needed under a new PR. It remains to be seen if the issues apply to the cube-sphere bcs.
Work is continuing on #687
Resolved.
Ok for
Still requires further examination. If there is an issue, it would not be fixed as part of this PR. Going forward, a fix and new bcs version may be needed under a new PR.
Mixed mode arithmetic is unfortunate but (probably) cannot be fixed without non-0-diff changes. Going forward, a fix and new bcs version may be needed under a new PR. |
This PR only affects boundary conditions creation package; for AGCM it is zero diff trivial. |
@mathomp4: I approved the PR but for reasons that remain a mystery to me, my approval does not count towards approval by @GEOS-ESM/surface-preproc-team. The python changes are trivial. Please super-approve when you get a chance. |
@gmao-rreichle I can approve for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for @GEOS-ESM/python-transition-team
I'm still confused by this. So I did a couple things. one, I removed you from the surface-preproc-team and then re-added you. Then I made you a Maintainer of it. Github can't say you don't belong now! |
Cleanup of make_bcs tools that generate raster and tile files.
Addresses EASE grid naming convention GEOSldas#605.
Major cleanup of
mkEASETilesParam.F90
, which was necessary to understand what the program is doing and how to possibly make it work for the high-resolution M01 (1-km) EASE grid.During cleanup, a couple of concerning issues were discovered:
Some cleanup of
mkLandRaster.F90
.Make sure to hide white-space changes when viewing differences.